Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(js): Simplify manual queue instrumentation code #11406

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 20, 2024

This PR updates the JS queue instrumentation instruction to use the new Sentry.getTraceData API instead of manually querying baggage and sentry-trace from the span.

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:24pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 3:24pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 3:24pm

@Lms24 Lms24 self-assigned this Sep 20, 2024
@Lms24 Lms24 requested review from a team, s1gr1d and andreiborza and removed request for a team September 20, 2024 14:49
Copy link

codecov bot commented Sep 20, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes (-0.0%) ⬇️

@Lms24 Lms24 merged commit f87b887 into master Oct 7, 2024
10 checks passed
@Lms24 Lms24 deleted the lms/ref-js-queue-instrumentation branch October 7, 2024 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants